fixup! URL Perms: Attachments controller

mysociety · Dec 19, 2023 · 8630adc · 8630adc
1 parent 4eb7fe8
commit 8630adc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/config/routes/redirects.rb b/config/routes/redirects.rb
@@ -35,11 +35,7 @@
 get '/request/:id(/*suffix)',
   format: false,
   constraints: { id: /\d+/, suffix: %r(response/\d+/attach(/html)?/\d+/.*) },
-  to: redirect(
-    -> (params, request) do
-      redirect_to_info_request_url_title_path(request: request, **params)
-    end
-  )
+  to: info_request_redirect
 
 get '/request/:id(/*suffix)',
   constraints: { id: /\d+/, suffix: %r(report/new) },

diff --git a/spec/routing/redirects_spec.rb b/spec/routing/redirects_spec.rb
@@ -18,4 +18,16 @@
     get('/request/105/followups/new')
     expect(response).to redirect_to('/request/the_cost_of_boring/followups/new')
   end
+
+  it 'routes numerical request attachment routes to URL title attachment routes' do
+    get('/request/105/response/1/attach/2/filename.txt')
+    expect(response).to redirect_to(
+      '/request/the_cost_of_boring/response/1/attach/2/filename.txt'
+    )
+
+    get('/request/105/response/1/attach/html/2/filename.txt.html')
+    expect(response).to redirect_to(
+      '/request/the_cost_of_boring/response/1/attach/html/2/filename.txt.html'
+    )
+  end
 end