fix(cronservice): prevent webhook callback never being executed

INT-572

src/Service/WpCronService.php

@@ -32,8 +32,28 @@ public function dispatch($callback, ...$args): void
      */
     public function schedule($callback, int $timestamp, ...$args): void
     {
+        if (! is_string($callback) && ! is_array($callback)) {
+            throw new InvalidArgumentException('Invalid callback');
+        }
+
         $hook = $callback;
 
+        /**
+         * TODO
+         * Temporarily execute webhooks, passed as a pseudo-instantiated class by the pdk,
+         * immediately until the cronservice in wp is fixed (ie it works 100% of the time)
+         */
+        if (is_array($callback)) {
+            [$class, $method] = $callback;
+            $instance = Pdk::get(get_class($class));
+
+            if (method_exists($instance, $method)) {
+                $instance->{$method}(...$args);
+
+                return;
+            }
+        }
+
         if (is_callable($callback)) {
             $hook = md5(uniqid('', true));
 
@@ -51,10 +71,6 @@ public function schedule($callback, int $timestamp, ...$args): void
      */
     private function getActions($callback, $hook)
     {
-        if (! is_string($callback) && ! is_array($callback)) {
-            throw new InvalidArgumentException('Invalid callback');
-        }
-
         $callable = $callback;
 
         if (is_array($callback)) {

tests/Datasets/callbacks.php

@@ -3,13 +3,8 @@
 
 declare(strict_types=1);
 
-use MyParcelNL\WooCommerce\Tests\Mock\MockCallableClass;
-
 dataset('callbacks', function () {
-    $mockClass = new MockCallableClass();
-
     return [
-        'instantiated class callback' => [[$mockClass, 'mock']],
         'static class callback'       => ['MyParcelNL\WooCommerce\Tests\Mock\MockCallableClass::mock'],
         'function callback'           => '\MyParcelNL\WooCommerce\Tests\mockFunction',
     ];

tests/Mock/MockCallableClass.php

@@ -15,4 +15,9 @@ public function mock(): string
     {
         return 'mocked';
     }
+
+    public function updateOption(string $option, $value): void
+    {
+        update_option($option, $value);
+    }
 }

tests/Unit/Service/WpCronServiceTest.php

@@ -8,6 +8,7 @@
 use InvalidArgumentException;
 use MyParcelNL\Pdk\Base\Contract\CronServiceInterface;
 use MyParcelNL\Pdk\Facade\Pdk;
+use MyParcelNL\WooCommerce\Tests\Mock\MockCallableClass;
 use MyParcelNL\WooCommerce\Tests\Mock\WordPressScheduledTasks;
 use MyParcelNL\WooCommerce\Tests\Uses\UsesMockWcPdkInstance;
 use function MyParcelNL\Pdk\Tests\usesShared;
@@ -73,6 +74,12 @@
     update_option(Pdk::get('webhookAddActions'), $actions);
 })->with('callbacks');
 
+it('executes instantiated class directly', function () {
+    $cronService = Pdk::get(CronServiceInterface::class);
+    $cronService->schedule([new MockCallableClass(), 'updateOption'], 2, 'arg1', 'arg2');
+    expect(get_option('arg1', []))->toBe('arg2');
+});
+
 it('throws exception when input is not a string or array', function () {
     /** @var \MyParcelNL\Pdk\Base\Contract\CronServiceInterface $cronService */
     $cronService = Pdk::get(CronServiceInterface::class);