refactor: make if statement readable

myparcelnl · Aug 1, 2024 · ae1c35a · ae1c35a
1 parent 97fd8d0
commit ae1c35a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/Hooks/CheckoutScriptHooks.php b/src/Hooks/CheckoutScriptHooks.php
@@ -199,14 +199,17 @@ private function shouldShowDeliveryOptions(): bool
             /**  @var WC_Product $product */
             $product = $cartItem['data'];
 
+            $productIsNotVirtual = ! $product->is_virtual();
+
             $deliveryOptionsEnabledWhenNotInStock = Settings::get(
                 CheckoutSettings::ENABLE_DELIVERY_OPTIONS_WHEN_NOT_IN_STOCK,
                 CheckoutSettings::ID
             );
 
-            if (! $product->is_virtual()
-                && ($deliveryOptionsEnabledWhenNotInStock
-                    || ! $product->is_on_backorder($cartItem['quantity']))) {
+            $backorderEnabledOrNotOnBackorder =
+                $deliveryOptionsEnabledWhenNotInStock || ! $product->is_on_backorder($cartItem['quantity']);
+
+            if ($productIsNotVirtual && $backorderEnabledOrNotOnBackorder) {
                 $showDeliveryOptions = true;
                 break;
             }