Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orders): fix automated order status settings not saving #290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EdieLemoine
Copy link
Contributor

Resolves #237

@EdieLemoine EdieLemoine requested a review from a team as a code owner November 22, 2024 15:20
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.37%. Comparing base (4c058c3) to head (34f4d6b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Pdk/Order/Service/PsOrderStatusService.php 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #290      +/-   ##
============================================
- Coverage     49.89%   49.37%   -0.53%     
+ Complexity      612      603       -9     
============================================
  Files           151      151              
  Lines          3950     3905      -45     
  Branches         55       55              
============================================
- Hits           1971     1928      -43     
+ Misses         1924     1922       -2     
  Partials         55       55              
Flag Coverage Δ
backend 76.96% <88.23%> (-0.33%) ⬇️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

PDK upgrade summary

♻️ The following packages were upgraded (from cache):

Package Old version New version
@myparcel-pdk/admin 1.5.4 1.5.5
@myparcel-pdk/admin-component-tests 1.5.4 1.5.5
@myparcel-pdk/admin-preset-bootstrap4 1.5.4 1.5.5
@myparcel-pdk/admin-preset-default 1.5.4 1.5.5

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 34f4d6b
Logs https://github.com/myparcelnl/prestashop/actions/runs/12418310567
Download https://github.com/myparcelnl/prestashop/suites/32276171279/artifacts/2344793820

@myparcel-bot myparcel-bot bot force-pushed the fix/order-status-automation branch 3 times, most recently from 637f151 to 5ea5b15 Compare November 27, 2024 18:08
@myparcel-bot myparcel-bot bot added the approved (Auto) label Dec 12, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/order-status-automation branch from 5ea5b15 to 222961e Compare December 19, 2024 10:37
@myparcel-bot myparcel-bot bot force-pushed the fix/order-status-automation branch from 222961e to 34f4d6b Compare December 19, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

'Automatisering Orderstatus' is not saved
3 participants