Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cpp): unify some platform code (audio slices, utils, ...) #166

Merged
merged 20 commits into from
Dec 9, 2023

Conversation

jhen0409
Copy link
Member

@jhen0409 jhen0409 commented Dec 5, 2023

Related #144.

Unify some code related to realtime transcription into C++:

  • audio slices
  • vad handles
  • abort handles
  • audio utils - save audio file by audioOutputPath

Some realtime state like sliceNSamples, sliceIndex are not moved. I'll consider move it and use thread instead of dispatch_queue / java thread in the future. (it will also help to implement #52)

TODO:

  • struct rnwhisper::job
  • move abort_map
  • move vad parmas
  • move audio slices
  • cpp audio utils (for save audio)
  • more tests

@jhen0409 jhen0409 marked this pull request as draft December 5, 2023 03:39
@jhen0409 jhen0409 marked this pull request as ready for review December 9, 2023 02:35
@jhen0409 jhen0409 changed the title feat(cpp): create job context for store abort flag and audio slices feat(cpp): unify some platform code (audio slices, utils, ...) Dec 9, 2023
@jhen0409 jhen0409 merged commit 913954c into main Dec 9, 2023
4 checks passed
@jhen0409 jhen0409 deleted the job-context branch December 9, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant