Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow strings for coreml assets #133

Merged
merged 1 commit into from
Sep 29, 2023
Merged

feat: allow strings for coreml assets #133

merged 1 commit into from
Sep 29, 2023

Conversation

JEF1056
Copy link
Contributor

@JEF1056 JEF1056 commented Sep 23, 2023 •
edited
Loading

This allows non-asset files to be used as coreml assets so downloaded coreml models can be used.

@JEF1056
feat: allow strings for coreml assets
433e043 
This allows non-asset files to be used as coreml assets so downloaded coreml models can be used
jhen0409
jhen0409 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jhen0409 jhen0409 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to this change, but note that the downloader still a very simple implementation, the purpose was only for fetch RN packager assets on dev mode.

Also, need to change downloadCoreMLAssets: value so it can be used for production.

@JEF1056 JEF1056 marked this pull request as ready for review September 29, 2023 00:30
@JEF1056
Copy link
Contributor Author

JEF1056 commented Sep 29, 2023

Confirmed working, ready to be merged

@jhen0409 jhen0409 merged commit 362274f into mybigday:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhen0409 jhen0409 jhen0409 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JEF1056 @jhen0409