feat: add todo

mybigday · Sep 23, 2023 · d956894 · d956894
1 parent 1967ede
commit d956894
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/android/src/main/java/com/rnwhisper/WhisperContext.java b/android/src/main/java/com/rnwhisper/WhisperContext.java
@@ -293,6 +293,7 @@ public void run() {
               Log.e(NAME, "Error transcribing realtime: " + e.getMessage());
             }
           }
+          // TODO: Append in real time so we don't need to keep all slices & also reduce memory usage
           Log.d(NAME, "Begin saving wav file to " + audioOutputPath);
           saveWavFile(concatShortBuffers(shortBufferSlices), audioOutputPath);
           if (!isTranscribing) {

diff --git a/ios/RNWhisperContext.mm b/ios/RNWhisperContext.mm
@@ -249,6 +249,7 @@ - (void)fullTranscribeSamples:(RNWhisperContextRecordState*) state {
 
         // Save wav if needed
         if (state->options[@"audioOutputPath"] != nil) {
+            // TODO: Append in real time so we don't need to keep all slices & also reduce memory usage
             [RNWhisperAudioUtils
                 saveWavFile:[RNWhisperAudioUtils concatShortBuffers:state->shortBufferSlices
                                 sliceNSamples:state->sliceNSamples]