Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Example Apps to TypeScript and Add Expo Support #913

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Convert Example Apps to TypeScript and Add Expo Support #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5189711
Use Expo example app on Expo 51
hellostu Oct 13, 2024
4f3cfb1
Support yarn 4.5.0 and start migrating ipad example app to expo
hellostu Oct 14, 2024
e3be7fb
Add lint
hellostu Oct 15, 2024
1cb5a12
Update build android
hellostu Oct 15, 2024
acdc6ac
Add ios Ci step
hellostu Oct 15, 2024
ab4dc7c
Make Xcode output prettier
hellostu Oct 15, 2024
59bc5cf
Support new arch
hellostu Oct 16, 2024
9d4abfe
Add build steps for both architectures
hellostu Oct 16, 2024
a162b60
Fix CI
hellostu Oct 16, 2024
ae8754f
Assemble release builds
hellostu Oct 16, 2024
502982e
Fig config plugin
hellostu Oct 16, 2024
d6dc05a
Different package names
hellostu Oct 16, 2024
482ad81
Build for device
hellostu Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node_modules
node_modules
apps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep eslint for apps.

We can follow our projects that already used TypeScript: https://github.com/mybigday/llama.rn/blob/f35545b92241d8cc9ee2b22b5ca4c02b395db9bb/package.json#L127-L203

Then the package also needs to be rewritten in TypeScript since it uses Flow, and it may need a build script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delayed reply. This was so the PR didn't get huge. I was going to do Typescript rewrite in another PR.

14 changes: 10 additions & 4 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,27 @@ module.exports = {
// 'plugin:ft-flow/recommended',
],
parser: 'hermes-eslint',
plugins: [
'ft-flow'
],
plugins: ['ft-flow'],
env: {
node: true,
browser: true,
jest: true,
},
rules: {
'import/order': 0,
'react/jsx-props-no-multi-spaces': 'off',
},
settings: {
'import/resolver': {
node: {
extensions: ['.js', '.jsx', '.json', '.native.js', '.ios.js', '.android.js'],
extensions: [
'.js',
'.jsx',
'.json',
'.native.js',
'.ios.js',
'.android.js',
],
},
},
},
Expand Down
Loading