fix(android): lora params

mybigday · Oct 2, 2023 · 5f94406 · 5f94406
1 parent ab783b9
commit 5f94406
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/android/src/main/java/com/rnllama/LlamaContext.java b/android/src/main/java/com/rnllama/LlamaContext.java
@@ -57,7 +57,7 @@ public LlamaContext(int id, ReactApplicationContext reactContext, ReadableMap pa
       // String lora,
       params.hasKey("lora") ? params.getString("lora") : "",
       // float lora_scaled,
-      params.hasKey("lora_scaled") ? (float) params.getDouble("lora_scaled") : 1.0f
+      params.hasKey("lora_scaled") ? (float) params.getDouble("lora_scaled") : 1.0f,
       // String lora_base,
       params.hasKey("lora_base") ? params.getString("lora_base") : "",
       // float rope_freq_base,

diff --git a/android/src/main/jni.cpp b/android/src/main/jni.cpp
@@ -161,12 +161,10 @@ Java_com_rnllama_LlamaContext_initContext(
     defaultParams.memory_f16 = memory_f16;
 
     const char *lora_chars = env->GetStringUTFChars(lora_str, nullptr);
-    if (lora_chars != nullptr) {
+    const char *lora_base_chars = env->GetStringUTFChars(lora_base_str, nullptr);
+    if (!lora_chars) {
         defaultParams.lora_adapter.push_back({lora_chars, lora_scaled});
-
-        const char *lora_base_chars = env->GetStringUTFChars(lora_base_str, nullptr);
         defaultParams.lora_base = lora_base_chars;
-
         defaultParams.use_mmap = false;
     }