Added finished callback to iterator.forRange() #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if typeof(args[args.length - 1]) is 'function' and typeof(args[args.length - 2]) is 'function' | ||
| finishedCallback = args.pop() | ||
| else | ||
| finishedCallback = ->{} |
There was a problem hiding this comment.
Don't need to set finishedCallback
my8bird
added a commit
that referenced
this pull request
Jul 13, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an additional, optional argument to iterator.forRange() which is a callback without argument.
This callback is called when the iterator has reached limitKey.
In any case, the finished callback is not called if any error occurs and the "normal" callback is guaranteed not to be called after the finished callback.
As the finished callback is optional, any call to forRange() not using the finished callback works exactly as before.
Currently there are no unit tests for this, but I tested the new feature in an expressjs app.
I think this feature is extremely important to node-leveldb - in my use case it is absolutely essential.
Also see Issue #28 for another request for this feature which should be fixed after merging this pull request.