Pause player #50
Open
Pause player #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
san650
approved these changes
Mar 8, 2017
addon/index.js
Outdated
| @@ -44,6 +44,8 @@ export function testStart(context) { | |||
| } | |||
|
|
|||
| export function testEnd() { | |||
| // After all the animations finished, we call destroy method in order to clean up elements and events | |||
| player().destroy(); | |||
addon/player.js
Outdated
| @@ -52,11 +52,54 @@ class Player extends BasePlayer { | |||
| this.moduleName = moduleName; | |||
| this.testName = testName; | |||
| this.success = true; | |||
| this.pausePromise = null; | |||
| QUnit.config.testTimeout = undefined; | |||
There was a problem hiding this comment.
Let's keep QUnit configurarion on the vendor file only, so the code is independent of the testing franework
san650
reviewed
Mar 12, 2017
addon/player.js
Outdated
| } | ||
|
|
||
| // Singleton instance of Player | ||
| let current = null; | ||
| var tsCurrentPlayer = null; |
There was a problem hiding this comment.
Variables inside ES6 modules are private to the module so it's not necessary to give it a globally unique name, just a module unique name, I guess current or currentPlayer is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pause and resume test execution.