Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard library for date and time when possible #1443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JuneStepp
Copy link

pytz dependency is removed. isodate is still needed for ISO durations and missing features in Python's ISO datetime parser.

closes #1442, closes #1420

pytz dependency is removed. isodate is still needed for ISO durations
and missing features in Python's ISO datetime parser.
@JuneStepp JuneStepp mentioned this pull request Nov 4, 2024
Copy link

@Mogost Mogost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code will not work in Python 3.8
But currently pyproject.toml has

requires-python = ">=3.8"

So python should be 3.8 should be dropped here or this PR should be dependent on another PR with dropping the mentioned support.

@JuneStepp
Copy link
Author

JuneStepp commented Nov 19, 2024

This code will not work in Python 3.8 But currently pyproject.toml has

requires-python = ">=3.8"

So python should be 3.8 should be dropped here or this PR should be dependent on another PR with dropping the mentioned support.

What part doesn't work on 3.8? I'm not using zoneinfo, because it wasn't actually necessary.

@Mogost
Copy link

Mogost commented Nov 20, 2024

@JuneStepp sorry I was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: use zoneinfo instead of pytz
2 participants