Releases/v1.6.0 #100
Merged
Releases/v1.6.0 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* VideoPlayerAdCallback added to ima. * Some error desc * Use aderror + cleanup * Doc clarification * Add kotlin APIs * cleanup * Actually set the ad player callback --------- Co-authored-by: Emily Dixon <[email protected]>
|
There's some fixes to make in the Core, so I'm going to hold this release until I can take care of them later in the week |
andrewjl-mux
approved these changes
Oct 2, 2024
|
oops |
andrewjl-mux
reviewed
Oct 2, 2024
| @@ -36,7 +36,7 @@ fun ImaAdsLoader.Builder.monitorWith( | |||
|
|
|||
| setAdEventListener(adsListener) | |||
| setAdErrorListener(adsListener) | |||
| customerAdPlayerAdCallback?.let { setVideoAdPlayerCallback(adsListener) } | |||
| setVideoAdPlayerCallback(adsListener) | |||
|
A draft release has been created for this version. Find it here! https://github.com/muxinc/mux-stats-sdk-media3/releases/tag/untagged-b8d1eb74621036df6eac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
VideoPlayerAdCallbacksupply it toImaAdsLoader.monitorWith(VideoPlayerAdCallback added to IMA integration #82).Fixes
Internal lib updates
stats.javato 8.1.2muxstats.androidto 1.4.2Co-authored-by: Emily Dixon [email protected]
Co-authored-by: Tomislav Kordic [email protected]
Co-authored-by: GitHub [email protected]