Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Chromecast provider to handle/avoid images which are "too big" #1806

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Allow Chromecast provider to handle/avoid images which are "too big" #1806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a069cd
Feat: setup.sh: Allow overriding which Python binary to use for venv
ijc Dec 16, 2024
a631d30
Fix: Limit images to 512x512
ijc Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion music_assistant/controllers/player_queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,7 +1261,7 @@ def player_media_from_queue_item(self, queue_item: QueueItem, flow_mode: bool) -
album.name if (album := getattr(queue_item.media_item, "album", None)) else ""
)
if queue_item.image:
media.image_url = self.mass.metadata.get_image_url(queue_item.image)
media.image_url = self.mass.metadata.get_image_url(queue_item.image, size=512)
return media

async def get_artist_tracks(self, artist: Artist) -> list[Track]:
Expand Down
2 changes: 1 addition & 1 deletion music_assistant/providers/chromecast/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ async def update_flow_metadata(self, castplayer: CastPlayer) -> None:
# update metadata of current item chromecast
if media_controller.status.media_custom_data["queue_item_id"] != current_item.queue_item_id:
image_url = (
self.mass.metadata.get_image_url(current_item.image)
self.mass.metadata.get_image_url(current_item.image, size=512)
if current_item.image
else MASS_LOGO_ONLINE
)
Expand Down
2 changes: 1 addition & 1 deletion scripts/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if [ -d "$env_name" ]; then
echo "Virtual environment '$env_name' already exists."
else
echo "Creating Virtual environment..."
python -m venv .venv
${PYTHON:-python} -m venv .venv
fi
echo "Activating virtual environment..."
source .venv/bin/activate
Expand Down
Loading