Fix: Add logging around Subsonic scrobble calls #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some disagreement about if the scrobble calls are actually occuring for some providers. Add logging around these calls to make sure the user knows they happened. Signed-off-by: Eric B Munson <[email protected]>
1 task
marcelveldt
reviewed
Dec 16, 2024
| await self._run_async(self._conn.scrobble, sid=item_id, submission=False) | ||
|
|
||
| async def on_streamed(self, streamdetails: StreamDetails, seconds_streamed: int) -> None: | ||
| """Handle callback when an item completed streaming.""" | ||
| self.logger.debug("on_streamed called for %s", streamdetails.item_id) |
There was a problem hiding this comment.
note that this will be called when the buffer is filled - its not perse the actual playback time, especially not for players that buffer a lot of data ahead such as sonos.
If you want actual played seconds we also have an event called by the queue manager.
marcelveldt
approved these changes
Dec 16, 2024
marcelveldt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some disagreement about if the scrobble calls are actually occuring for some providers. Add logging around these calls to make sure the user knows they happened.