Skip to content

Commit

Permalink
More shellcheck fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
sandervankasteel committed Oct 30, 2024
1 parent 32aed2e commit 9c6ae91
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions check_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ TAG_NAME=$(curl -fsL \
-H "X-GitHub-Api-Version: 2022-11-28" \
https://api.github.com/repos/music-assistant/companion/releases | jq '.[0].tag_name')

export MUSIC_COMPANION_VERSION=$(echo "$TAG_NAME" | cut -d"v" -f 2 | cut -d"\"" -f 1)
export MUSIC_COMPANION_VERSION=$(echo "${TAG_NAME}" | cut -d"v" -f 2 | cut -d"\"" -f 1)

Check failure on line 9 in check_release.sh

View workflow job for this annotation

GitHub Actions / test-bot (ubuntu-22.04)

Declare and assign separately to avoid masking return values.

for i in "${RELEASES[@]}"
do
ARCH=$(echo "${i}" | cut -f1 -d_ | tr '[:upper:]' '[:lower:]')

Check failure on line 13 in check_release.sh

View workflow job for this annotation

GitHub Actions / test-bot (ubuntu-22.04)

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).
URL="https://github.com/music-assistant/companion/releases/download/v${MUSIC_COMPANION_VERSION}/Music.Assistant.Companion_${ARCH}.app.tar.gz"
curl -sLO $URL
curl -sLO "${URL}"

SHA_FILE=$(shasum -a 256 "Music.Assistant.Companion_${ARCH}.app.tar.gz" | cut -d" " -f 1)

Check failure on line 17 in check_release.sh

View workflow job for this annotation

GitHub Actions / test-bot (ubuntu-22.04)

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).

export $i=$SHA_FILE
export "${i}"="${SHA_FILE}"
done

cat companion.template.rb | envsubst > Casks/companion.rb

Check failure on line 22 in check_release.sh

View workflow job for this annotation

GitHub Actions / test-bot (ubuntu-22.04)

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).

Check failure on line 22 in check_release.sh

View workflow job for this annotation

GitHub Actions / test-bot (ubuntu-22.04)

Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

0 comments on commit 9c6ae91

Please sign in to comment.