Create a Loader for the generateSimplifiedGeo Function #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor Image component + add ktx support (musehq#99) * Refactor Image component + add ktx support * Make Texture Component more general * export index type & clean up syntax Co-authored-by: Alex Shortt <[email protected]> Co-authored-by: Muse <[email protected]> * Collidable Modifier + Refactors (musehq#100) * add collidable modifier * replace bvh logic with geo simplifier * add optional raycaster prop to interactable modifier * slight refactors to image idea * fix up exports * clean up keyboard layout code, don't run check if in iframe * v2.1.0 Co-authored-by: stevenpaulhoward <[email protected]> Co-authored-by: Muse <[email protected]>
Upgrade Examples, Improve Site
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SpacesVR
Collidablemodifier can be an expensive and time consuming calculation. This PR extends the Three.JSLoaderclass to defineGenerateSimplifiedGeoLoaderso theLoadingManagercan identify when the Collidable function is finished.