Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter fix #96

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Twitter fix #96

merged 2 commits into from
Dec 16, 2024

Conversation

murdercode
Copy link
Owner

This pull request includes a significant update to the getOembed method in the TwitterShortcode class to improve error handling and code readability.

Error handling improvements:

  • src/Shortcodes/TwitterShortcode.php: Added a check to return null if the curl_exec function fails and modified the JSON decoding to return an associative array. This ensures that the method handles errors more gracefully and avoids potential null pointer exceptions.

Code readability improvements:

@murdercode murdercode merged commit a3a6921 into main Dec 16, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant