Improve mails template #1704
Draft
Improve mails template #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lauramangifesta, take a look this PR |
fedescarpa
force-pushed
the
improve-mails-template
branch
from
378e30c to
7466339
Compare
fedescarpa
force-pushed
the
improve-mails-template
branch
from
7466339 to
9682cd3
Compare
fedescarpa
force-pushed
the
improve-mails-template
branch
from
9682cd3 to
4a04b2b
Compare
julian-berbel
approved these changes
Oct 25, 2021
| @@ -39,7 +39,7 @@ pt: | |||
| blocked_forum_explanation: Você está no meio de um exame agora? | |||
| cancel: Cancelar | |||
| certificate: Certificado | |||
| certificate_available: Seu certificado já está disponível | |||
| certificate_available: Seu certificado já está disponível. | |||
There was a problem hiding this comment.
Let's check that punctuation is consistent through locales. This one seems to have an exclamation mark in english, nothing in spanish, and a period in portuguese now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEED TO MARGE THIS PR BEFORE => #1701
🎯 Goal
Improve mails template
📸 Screenshots