Feature used parameter expectation #266
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-berbel
approved these changes
Mar 26, 2020
| hasUnusedParameters (js "function x(m2, m2) { g(m1); return m2 } ") `shouldBe` False | ||
|
|
||
| it "is False when uses all its parameters in return" $ do | ||
| hasUnusedParameters (js "function x(m2, m2) { return m1 + m2 } ") `shouldBe` False |
There was a problem hiding this comment.
I believe parameters in these two tests should be x(m1, m2)
| describe "hasUnusedParameters" $ do | ||
| it "is False for methods of all kinds" $ do | ||
| hasUnusedParameters (js "var o = {x: function(m) { return 4; }}") `shouldBe` False | ||
| hasUnusedParameters (js "var o = {x: function(m) { return m; }}") `shouldBe` False |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress since I want to add this check as an inspection instead of an smell, due to backward compatibility issues.