-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reduce image size with distroless image #38
base: master
Are you sure you want to change the base?
Conversation
- Replace entrypoint script with rust binary - To be able to run without a shell - Copy over only needed shared libs
How much size reduction does the switch to rust actually give us? I wouldn't expect the shell binary to be that large tbh 🤔 |
The switch to using a Rust binary does not reduce the size at all.
In general, the distroless images have no shell though by default (see also their README). That's the reason why I replaced the shell script with a single binary instead. I picked Rust just because I wanted to use it more. |
Not sure I feel good about using Rust here. While it is a language that I wanted to learn at some point, I am not yet familiar with it. This will make maintaining this somewhat difficult. Plus, I don't know how well versed potential contributors are in Rust. Would be a shame to lose potential contributors because of this 👀 |
- To fix Mumble 1.4.287 build - Allow choosing debian version with ARGs
That's of course understandable. I also can't share any experience how much effort maintaining the To avoid replacing One (major) drawback though: I couldn't find a version of the busybox image corresponding to Debian 11 yet with a quick search. On Debian 12, the current v1.4.287 release of Mumble won't build because of the OpenSSL version jump from 1.x to 3.x. What are your thoughts on this? |
As mentioned in #25, I have worked on a smaller mumble image for personal use. The PR is not yet ready for merging as there are still some TODOs to address. I initially built this a longer time ago so I still need to check whether no functionality is lost by this PR.
Also please note that I'm still learning rust and do not claim this is the most elegant way to replace
entrypoint.sh
. I did this mainly as a learning opportunity.Main Differences
Open TODOs
entrypoint.sh
are implemented