Skip to content
CI

Fix parse reason #3872

Sign in to view logs

Fix parse reason

Fix parse reason #3872

GitHub Actions / clippy failed Oct 17, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (6)

sdk/core/src/retrieve_tx_on_network.rs|152 col 13| warning: the following explicit lifetimes could be elided: 'a
--> sdk/core/src/retrieve_tx_on_network.rs:152:13
|
152 | fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: #[warn(clippy::needless_lifetimes)] on by default
help: elide the lifetimes
|
152 - fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
152 + fn find_log(tx: &mut TransactionOnNetwork) -> Option<&mut Events> {
|
sdk/core/src/retrieve_tx_on_network.rs|152 col 13| warning: the following explicit lifetimes could be elided: 'a
--> sdk/core/src/retrieve_tx_on_network.rs:152:13
|
152 | fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: #[warn(clippy::needless_lifetimes)] on by default
help: elide the lifetimes
|
152 - fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
152 + fn find_log(tx: &mut TransactionOnNetwork) -> Option<&mut Events> {
|
sdk/core/src/retrieve_tx_on_network.rs|204 col 54| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> sdk/core/src/retrieve_tx_on_network.rs:204:54
|
204 | let message = extract_message_from_string_reason(&reason);
| ^^^^^^^ help: change this to: reason
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
sdk/core/src/retrieve_tx_on_network.rs|219 col 54| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> sdk/core/src/retrieve_tx_on_network.rs:219:54
|
219 | let message = extract_message_from_string_reason(&reason);
| ^^^^^^^ help: change this to: reason
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
sdk/core/src/retrieve_tx_on_network.rs|382 col 54| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> sdk/core/src/retrieve_tx_on_network.rs:382:54
|
382 | serde_json::from_str::(&tx_str).unwrap();
| ^^^^^^^ help: change this to: tx_str
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
sdk/core/src/retrieve_tx_on_network.rs|384 col 54| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> sdk/core/src/retrieve_tx_on_network.rs:384:54
|
384 | serde_json::from_str::(&expected_tx_str).unwrap();
| ^^^^^^^^^^^^^^^^ help: change this to: expected_tx_str
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Filtered Findings (0)

Annotations

Check warning on line 152 in sdk/core/src/retrieve_tx_on_network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] sdk/core/src/retrieve_tx_on_network.rs#L152 

warning: the following explicit lifetimes could be elided: 'a
   --> sdk/core/src/retrieve_tx_on_network.rs:152:13
    |
152 | fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
    |             ^^       ^^                                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
152 - fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
152 + fn find_log(tx: &mut TransactionOnNetwork) -> Option<&mut Events> {
    |
Raw output 
sdk/core/src/retrieve_tx_on_network.rs:152:13:w:warning: the following explicit lifetimes could be elided: 'a
   --> sdk/core/src/retrieve_tx_on_network.rs:152:13
    |
152 | fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
    |             ^^       ^^                                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
152 - fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
152 + fn find_log(tx: &mut TransactionOnNetwork) -> Option<&mut Events> {
    |


__END__

Check warning on line 152 in sdk/core/src/retrieve_tx_on_network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] sdk/core/src/retrieve_tx_on_network.rs#L152 

warning: the following explicit lifetimes could be elided: 'a
   --> sdk/core/src/retrieve_tx_on_network.rs:152:13
    |
152 | fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
    |             ^^       ^^                                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
152 - fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
152 + fn find_log(tx: &mut TransactionOnNetwork) -> Option<&mut Events> {
    |
Raw output 
sdk/core/src/retrieve_tx_on_network.rs:152:13:w:warning: the following explicit lifetimes could be elided: 'a
   --> sdk/core/src/retrieve_tx_on_network.rs:152:13
    |
152 | fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
    |             ^^       ^^                                      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
152 - fn find_log<'a>(tx: &'a mut TransactionOnNetwork) -> Option<&'a mut Events> {
152 + fn find_log(tx: &mut TransactionOnNetwork) -> Option<&mut Events> {
    |


__END__

Check warning on line 204 in sdk/core/src/retrieve_tx_on_network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] sdk/core/src/retrieve_tx_on_network.rs#L204 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:204:54
    |
204 |     let message = extract_message_from_string_reason(&reason);
    |                                                      ^^^^^^^ help: change this to: `reason`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output 
sdk/core/src/retrieve_tx_on_network.rs:204:54:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:204:54
    |
204 |     let message = extract_message_from_string_reason(&reason);
    |                                                      ^^^^^^^ help: change this to: `reason`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 219 in sdk/core/src/retrieve_tx_on_network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] sdk/core/src/retrieve_tx_on_network.rs#L219 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:219:54
    |
219 |     let message = extract_message_from_string_reason(&reason);
    |                                                      ^^^^^^^ help: change this to: `reason`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output 
sdk/core/src/retrieve_tx_on_network.rs:219:54:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:219:54
    |
219 |     let message = extract_message_from_string_reason(&reason);
    |                                                      ^^^^^^^ help: change this to: `reason`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 382 in sdk/core/src/retrieve_tx_on_network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] sdk/core/src/retrieve_tx_on_network.rs#L382 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:382:54
    |
382 |         serde_json::from_str::<TransactionOnNetwork>(&tx_str).unwrap();
    |                                                      ^^^^^^^ help: change this to: `tx_str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output 
sdk/core/src/retrieve_tx_on_network.rs:382:54:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:382:54
    |
382 |         serde_json::from_str::<TransactionOnNetwork>(&tx_str).unwrap();
    |                                                      ^^^^^^^ help: change this to: `tx_str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 384 in sdk/core/src/retrieve_tx_on_network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] sdk/core/src/retrieve_tx_on_network.rs#L384 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:384:54
    |
384 |         serde_json::from_str::<TransactionOnNetwork>(&expected_tx_str).unwrap();
    |                                                      ^^^^^^^^^^^^^^^^ help: change this to: `expected_tx_str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output 
sdk/core/src/retrieve_tx_on_network.rs:384:54:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> sdk/core/src/retrieve_tx_on_network.rs:384:54
    |
384 |         serde_json::from_str::<TransactionOnNetwork>(&expected_tx_str).unwrap();
    |                                                      ^^^^^^^^^^^^^^^^ help: change this to: `expected_tx_str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__
View more details on GitHub Actions