fix/sdk: Allow signature to be empty in core sdk TransactionOnNetwork #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-marinica
approved these changes
Oct 1, 2024
BiancaIalangi
approved these changes
Oct 1, 2024
mihaicalinluca
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I recently ran into an issue with the Rust SDK not being able to retrieve
unsignedtransactions from the blockchain (i.e: inter contract transactions in a callback):https://devnet-gateway.multiversx.com/transaction/34cd9c6d0f68c0975971352ed4dcaacc1acd9a2dbd8f5840a2866d09b1d72298?withResults=true
It seems that the issue was that in the SDK the
signaturefield was required, while for these kinds of transactions there is no signature.Added a default value to the field in order to preserve backwards compatibility.