Allow bech32 address value payload

[EtienneWallet]

Context

Currently, bech32 string cannot be directly passed as tranaction argument to the smart-contract factories. Indeed, this leads to an error when setting the payload of an AddressValue

AddressValue().set_payload("erd1qyu5wthldzr8wx5c9ucg8kjagg0jfs53s8nr3zpz3hypefsdd8ssycr6th")

    def set_payload(self, value: Any):
        if isinstance(value, dict):
            value = cast(Dict[str, str], value)
            pubkey = self._extract_pubkey_from_dict(value)
        else:
>           pubkey = bytes(value)
E           TypeError: string argument without an encoding

multiversx_sdk/abi/address_value.py:52: TypeError

Proposed Change

If the set_payload method receives a string, it should try to parse it as bech32 to extract the pubkey

def set_payload(self, value: Any):
        if isinstance(value, dict):
            value = cast(Dict[str, str], value)
            pubkey = self._extract_pubkey_from_dict(value)
        elif isinstance(value, str):
            address = Address.new_from_bech32(value)
            pubkey = address.pubkey
        else:
            pubkey = bytes(value)

This would allow to pass effectively bech32 strings as transaction arguments to the smart-contract factories.

[popenta]

Looks good!

[popenta]

Use to_bech32() instead.

[popenta]

I'd say use get_public_key() to stay consistent throughout the class.

[andreibancioiu]

🎉 Nice!

(the comments from Alex)

[EtienneWallet]

requested changes applied!

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
multiversx_sdk/abi
address_value.py
multiversx_sdk/smart_contracts
smart_contract_controller.py
Project Total

This report was generated by python-coverage-comment-action