Update tsconfig.json #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package can't be used appropriately with the current package.json paths to the lib directory and tsconfig.json file setup. The solution would be the changes in tsconfig.json: 1. remove tests from the `lib` output; we don't need them, do we? 2. This will flatten the lib directory to match paths defined in the package.json As additional improvements (not added here): 1. there is an npm audit error that can be fixed by running `npm audit fix`. The package-lock.json will need to be pushed then. I wanted to avoid touching the package-lock here.
|
This requires merging. Important modification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package can't be used appropriately with the current package.json paths to the lib directory and current tsconfig.json file setup.
The solution would be the changes in tsconfig.json:
liboutput; we don't need them, do we?As additional improvements (not added here):
npm audit fix. The package-lock.json will need to be pushed then. I wanted to avoid touching the package-lock here.I saw that it is used like:
@multiversx/sdk-transaction-decoder/lib/src/transaction.decoder, so it will probably be a breaking change (sort of, breaking by fixing ;)), but I think it would be worth fixing that