Remove gasEstimater and related code #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielailie
changed the base branch from
main
to
TOOL-407-update-address-to-follow-specs
andreibancioiu
previously approved these changes
Dec 17, 2024
popenta
previously approved these changes
Dec 17, 2024
| constructor(options: { config: IConfig }) { | ||
| this.config = options.config; | ||
| this.tokenComputer = new TokenComputer(); | ||
| this.tokenTransfersDataBuilder = new TokenTransfersDataBuilder(); | ||
| } | ||
|
|
||
| private ensureConfigIsDefined() { |
There was a problem hiding this comment.
I think this can be removed since now the only way to use the factory is to instantiate it with a config
Base automatically changed from
TOOL-407-update-address-to-follow-specs
to
feat/next
December 18, 2024 09:29
danielailie
dismissed stale reviews from popenta and andreibancioiu
The base branch was changed.
andreibancioiu
approved these changes
Dec 18, 2024
popenta
approved these changes
Dec 18, 2024
danielailie
deleted the
TOOL-408-remove-i-gas-estimater-and-related-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.