Code enhancements #354
Merged
Code enhancements #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Nov 17, 2023
src/smartcontracts/code.ts
Outdated
| @@ -25,4 +37,12 @@ export class Code { | |||
| valueOf(): Buffer { | |||
| return Buffer.from(this.hex, "hex"); | |||
| } | |||
|
|
|||
| computeHash(): Hash { | |||
There was a problem hiding this comment.
I think this can directly be a Buffer. At some point, we might remove the Hash object. E.g. see the sdk-specs for transaction hash: https://github.com/multiversx/mx-sdk-specs/blob/main/sdk-core/transaction.md
popenta
reviewed
Nov 17, 2023
popenta
previously approved these changes
Nov 17, 2023
michavie
dismissed stale reviews from popenta and andreibancioiu
via
f4b91cd
andreibancioiu
approved these changes
Nov 17, 2023
popenta
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromHex