added toast progress #61
Conversation
| @@ -71,6 +71,7 @@ | |||
| "@swc/jest": "^0.2.36", | |||
| "@types/jest": "29.5.13", | |||
| "@types/lodash": "4.17.4", | |||
| "@types/lodash.isequal": "4.5.8", | |||
There was a problem hiding this comment.
remove lodash dependency and add depenency for lodash.isstring, lodash.isequal
|
|
||
| export class ToastManager { | ||
| private transactionToastsList: TransactionToastList | undefined; | ||
| private toastProgressManager: ToastProgressManager; |
There was a problem hiding this comment.
ProgressManager and LifetimeManager
| if (!this.transactionToastsList) { | ||
| this.transactionToastsList = | ||
| private handleProgressUpdate = (toastId: string, progress: number) => { | ||
| const toastIndex = this.transactionToasts.findIndex( |
There was a problem hiding this comment.
in this case is not fit Map usually Map is use to map object to value is very similar with Record<type,type> but it can support also functions
src/core/managers/ToastManager/helpers/ToastLifeTimeoutManager.ts
Outdated
Show resolved
Hide resolved
| import { getAddressFromDataField } from 'utils'; | ||
| import { isCrossShardTransaction } from './isCrossShardTransaction'; | ||
|
|
||
| export const getAreTransactionsOnSameShard = ( |
|
|
||
| const invalidToastData: IToastDataState = { | ||
| id: toastId, | ||
| icon: 'ban', |
There was a problem hiding this comment.
consider creating an enum for icons so we can replace them easyer in the future
src/core/methods/initApp/initApp.ts
Outdated
| @@ -65,7 +65,9 @@ export async function initApp({ | |||
| } | |||
|
|
|||
| trackTransactions(); | |||
| const toastManager = new ToastManager(); | |||
| const toastManager = new ToastManager({ | |||
| successfulToastLifetime: 10000 | |||
There was a problem hiding this comment.
check if this is currenlty the same as today and maybe define it in constants folder
There was a problem hiding this comment.
i add it to dapConfig because it doesn't have a default, if they are not provided in the dapp it will not expire
| const zeroAddress = Buffer.alloc(32).fill(0); | ||
| return pubKey.equals(zeroAddress); | ||
| }; | ||
| export const getShardOfAddress = (hexPubKey: any) => { |
There was a problem hiding this comment.
it cannot without rewriting the function
|
|
||
| switch (status) { | ||
| case TransactionBatchStatusesEnum.signed: | ||
| case TransactionBatchStatusesEnum.sent: |
There was a problem hiding this comment.
63,64 can be put last
case TransactionBatchStatusesEnum.signed:
case TransactionBatchStatusesEnum.sent:
default:
return pendingToastData;
or simply remove them and it will be on default
| } | ||
|
|
||
| export class LifetimeManager { | ||
| // eslint-disable-next-line no-undef |
There was a problem hiding this comment.
for some reason(don't know yet why) it doesn't recognise NodeJS
| } | ||
|
|
||
| export class ProgressManager { | ||
| // eslint-disable-next-line no-undef |
There was a problem hiding this comment.
for some reason(don't know yet why) it doesn't recognise NodeJS
|
|
||
| return transactions.reduce( | ||
| (prevTxIsSameShard: boolean, { receiver, data }: SignedTransactionType) => { | ||
| const receiverAddress = getAddressFromDataField({ |
There was a problem hiding this comment.
it's from old sdk-dapp, it was taken from there
| } catch (_err) { | ||
| return -1; | ||
| } | ||
| }; |
| } | ||
|
|
||
| return `${processedTransactions} / ${totalTransactions} transactions processed`; | ||
| }; |
| } catch (_err) { | ||
| return false; | ||
| } | ||
| } |
Feature
Added toast progress tracking and toast lifetime
Contains breaking changes
[x] No
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing
[] Unit tests