pair hooks again #825
Merged
pair hooks again #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract comparison - from e227609 to 04890fe
|
alyn509
previously approved these changes
Feb 6, 2024
| hook.dest_address, | ||
| hook.endpoint_name, | ||
| ) | ||
| .with_raw_arguments(call_args.clone()) |
There was a problem hiding this comment.
Is this wanted behavior? The only parameter to be the Pair?
Is there any case where a hook would need personalized parameters?
There was a problem hiding this comment.
Yes, plenty of endpoints have their own parameters.
| .execute_on_dest_context_with_back_transfers::<MultiValueEncoded<ManagedBuffer>>(); | ||
|
|
||
| require!( | ||
| back_transfers.esdt_payments.len() == payments_len, |
There was a problem hiding this comment.
The egld value is ignored. Is there any case where EGLD would be used?
There was a problem hiding this comment.
Nope, only ESDT.
CostinCarabas
approved these changes
Feb 6, 2024
andreiblt1304
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.