Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy increase energy #778

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Proxy increase energy #778

merged 7 commits into from
Oct 2, 2023

Conversation

dorin-iancu
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Contract comparison - from 2fd2e4c to a7ca9e6

Path                                                                                             size                  has-allocator                     has-format
mx-exchange-sc
- pause-all/pause-all.wasm 5438 No No
mx-exchange-sc/dex
- farm/farm.wasm 38165 No No
- farm-with-locked-rewards/farm-with-locked-rewards.wasm 37846 No No
- governance/governance.wasm 17283 No No
- pair
- - pair.wasm 30515 No No
- - pair-full.wasm 31971 No No
- - safe-price-view.wasm 7862 No No
- pair-mock/pair-mock.wasm 5474 No No
- price-discovery/price-discovery.wasm 16254 No No
- proxy-deployer/proxy-deployer.wasm 4457 No No
- router/router.wasm 25991 No No
mx-exchange-sc/energy-integration
- energy-factory-mock/energy-factory-mock.wasm 4233 No No
- energy-update/energy-update.wasm 1510 No No
- fees-collector/fees-collector.wasm 18320 No No
- governance-v2/governance-v2.wasm 16693 No No
mx-exchange-sc/farm-staking
- farm-staking/farm-staking.wasm 41505 No No
- farm-staking-proxy/farm-staking-proxy.wasm 22835 No No
- metabonding-staking/metabonding-staking.wasm 9595 No No
mx-exchange-sc/locked-asset
- distribution/distribution.wasm 14358 No No
- energy-factory/energy-factory.wasm 34193 ➡️ 34616 🔴 No No
- factory/factory.wasm 30375 No No
- lkmex-transfer/lkmex-transfer.wasm 11214 No No
- locked-token-wrapper/locked-token-wrapper.wasm 14291 No No
- proxy_dex/proxy_dex.wasm 34335 ➡️ 35671 🔴 No No
- simple-lock/simple-lock.wasm 24300 No No
- simple-lock-whitelist/simple-lock-whitelist.wasm 25946 No No
- token-unstake/token-unstake.wasm 13625 No No

@dorin-iancu dorin-iancu marked this pull request as ready for review September 29, 2023 07:11
sasurobert
sasurobert previously approved these changes Sep 29, 2023
View reviewed changes
alyn509
alyn509 previously approved these changes Sep 29, 2023
View reviewed changes
@CostinCarabas CostinCarabas self-requested a review September 29, 2023 08:17
@dorin-iancu dorin-iancu dismissed stale reviews from alyn509 and sasurobert via a7ca9e6 September 29, 2023 08:27
psorinionut
psorinionut reviewed Sep 29, 2023
View reviewed changes
locked-asset/proxy_dex/src/energy_update.rs
@@ -46,9 +46,6 @@ pub trait EnergyUpdateModule:
.get_token_attributes(token_id, token_nonce);
energy.update_after_unlock_any(token_amount, attributes.unlock_epoch, current_epoch);
} else if token_id == &old_locked_token_id {
if self.blockchain().is_smart_contract(user) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed. Now contracts can have energy.

@dorin-iancu dorin-iancu merged commit 711aede into main Oct 2, 2023
4 checks passed
@dorin-iancu dorin-iancu deleted the proxy-dex-extend branch October 2, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psorinionut psorinionut psorinionut approved these changes

@CostinCarabas CostinCarabas CostinCarabas approved these changes

@sasurobert sasurobert sasurobert approved these changes

@alyn509 alyn509 alyn509 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dorin-iancu @sasurobert @CostinCarabas @alyn509 @psorinionut