Skip to content
On pull request, build contracts

Upgrade contracts to 0.43.4 #40

Sign in to view logs

Upgrade contracts to 0.43.4

Upgrade contracts to 0.43.4 #40

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy failed Oct 2, 2023 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (4)

contracts/multisig/tests/multisig_blackbox_test.rs|403 col 76| warning: redundant clone
--> contracts/multisig/tests/multisig_blackbox_test.rs:403:76
|
403 | let action_id = state.propose_add_board_member(new_board_member_address.clone());
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/multisig/tests/multisig_blackbox_test.rs:403:52
|
403 | let action_id = state.propose_add_board_member(new_board_member_address.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
contracts/multisig/tests/multisig_blackbox_test.rs|458 col 37| warning: redundant clone
--> contracts/multisig/tests/multisig_blackbox_test.rs:458:37
|
458 | new_user_address.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/multisig/tests/multisig_blackbox_test.rs:458:21
|
458 | new_user_address.clone(),
| ^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/multisig/tests/multisig_blackbox_test.rs|539 col 69| warning: redundant clone
--> contracts/multisig/tests/multisig_blackbox_test.rs:539:69
|
539 | let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/multisig/tests/multisig_blackbox_test.rs:539:52
|
539 | let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
| ^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/multisig/tests/multisig_blackbox_test.rs|568 col 26| warning: redundant clone
--> contracts/multisig/tests/multisig_blackbox_test.rs:568:26
|
568 | factorial_address.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/multisig/tests/multisig_blackbox_test.rs:568:9
|
568 | factorial_address.clone(),
| ^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Filtered Findings (0)

Annotations

Check warning on line 403 in contracts/multisig/tests/multisig_blackbox_test.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/multisig/tests/multisig_blackbox_test.rs#L403 

warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:403:76
    |
403 |     let action_id = state.propose_add_board_member(new_board_member_address.clone());
    |                                                                            ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:403:52
    |
403 |     let action_id = state.propose_add_board_member(new_board_member_address.clone());
    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
    = note: `#[warn(clippy::redundant_clone)]` on by default
Raw output 
contracts/multisig/tests/multisig_blackbox_test.rs:403:76:w:warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:403:76
    |
403 |     let action_id = state.propose_add_board_member(new_board_member_address.clone());
    |                                                                            ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:403:52
    |
403 |     let action_id = state.propose_add_board_member(new_board_member_address.clone());
    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
    = note: `#[warn(clippy::redundant_clone)]` on by default


__END__

Check warning on line 458 in contracts/multisig/tests/multisig_blackbox_test.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/multisig/tests/multisig_blackbox_test.rs#L458 

warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:458:37
    |
458 |                     new_user_address.clone(),
    |                                     ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:458:21
    |
458 |                     new_user_address.clone(),
    |                     ^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Raw output 
contracts/multisig/tests/multisig_blackbox_test.rs:458:37:w:warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:458:37
    |
458 |                     new_user_address.clone(),
    |                                     ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:458:21
    |
458 |                     new_user_address.clone(),
    |                     ^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone


__END__

Check warning on line 539 in contracts/multisig/tests/multisig_blackbox_test.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/multisig/tests/multisig_blackbox_test.rs#L539 

warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:539:69
    |
539 |     let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
    |                                                                     ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:539:52
    |
539 |     let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
    |                                                    ^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Raw output 
contracts/multisig/tests/multisig_blackbox_test.rs:539:69:w:warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:539:69
    |
539 |     let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
    |                                                                     ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:539:52
    |
539 |     let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
    |                                                    ^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone


__END__

Check warning on line 568 in contracts/multisig/tests/multisig_blackbox_test.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/multisig/tests/multisig_blackbox_test.rs#L568 

warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:568:26
    |
568 |         factorial_address.clone(),
    |                          ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:568:9
    |
568 |         factorial_address.clone(),
    |         ^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Raw output 
contracts/multisig/tests/multisig_blackbox_test.rs:568:26:w:warning: redundant clone
   --> contracts/multisig/tests/multisig_blackbox_test.rs:568:26
    |
568 |         factorial_address.clone(),
    |                          ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> contracts/multisig/tests/multisig_blackbox_test.rs:568:9
    |
568 |         factorial_address.clone(),
    |         ^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone


__END__
View more details on GitHub Actions