Skip to content

proxy deployer contract #91

proxy deployer contract

proxy deployer contract #91

Triggered via pull request November 20, 2023 23:44
Status Success
Total duration 5m 22s
Artifacts 1
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 8 warnings
[clippy] contracts/proxy-deployer/tests/proxy_deployer_blackbox_test.rs#L35: contracts/proxy-deployer/tests/proxy_deployer_blackbox_test.rs#L35
error[E0277]: the trait bound `adder::Proxy<multiversx_sc_scenario::api::VMHooksApi<multiversx_sc_scenario::api::impl_vh::static_api::StaticApiBackend>>: multiversx_sc::contract_base::ProxyObjBase` is not satisfied --> contracts/proxy-deployer/tests/proxy_deployer_blackbox_test.rs:35:24 | 35 | template_contract: TemplateContract, | ^^^^^^^^^^^^^^^^ the trait `multiversx_sc::contract_base::ProxyObjBase` is not implemented for `adder::Proxy<multiversx_sc_scenario::api::VMHooksApi<multiversx_sc_scenario::api::impl_vh::static_api::StaticApiBackend>>` | = help: the following other types implement trait `multiversx_sc::contract_base::ProxyObjBase`: multiversx_sc_modules::dns::dns_proxy::Proxy<A> proxy_deployer::Proxy<A> note: required by a bound in `multiversx_sc_scenario::ContractInfo` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/multiversx-sc-scenario-0.43.4/src/facade/contract_info.rs:14:28 | 14 | pub struct ContractInfo<P: ProxyObjBase> { | ^^^^^^^^^^^^ required by this bound in `ContractInfo`
[clippy] contracts/proxy-deployer/tests/proxy_deployer_blackbox_test.rs#L35: contracts/proxy-deployer/tests/proxy_deployer_blackbox_test.rs#L35
error[E0277]: the trait bound `multiversx_sc_scenario::api::VMHooksApi<multiversx_sc_scenario::api::impl_vh::static_api::StaticApiBackend>: multiversx_sc::api::vm_api::VMApi` is not satisfied --> contracts/proxy-deployer/tests/proxy_deployer_blackbox_test.rs:35:24 | 35 | template_contract: TemplateContract, | ^^^^^^^^^^^^^^^^ the trait `multiversx_sc::api::vm_api::VMApi` is not implemented for `multiversx_sc_scenario::api::VMHooksApi<multiversx_sc_scenario::api::impl_vh::static_api::StaticApiBackend>` | = help: the following other types implement trait `multiversx_sc::api::vm_api::VMApi`: multiversx_sc::api::external_view::ev_wrapper::ExternalViewApi<A> multiversx_sc::api::uncallable::UncallableApi note: required by a bound in `adder::Proxy` --> /home/runner/work/mx-contracts-rs/mx-contracts-rs/contracts/adder/src/adder.rs:7:1 | 7 | #[multiversx_sc::contract] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Proxy` = note: this error originates in the attribute macro `multiversx_sc::contract` (in Nightly builds, run with -Z macro-backtrace for more info)
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L80: contracts/proxy-deployer/src/contract_interactions.rs#L80
warning: redundant clone --> contracts/proxy-deployer/src/contract_interactions.rs:80:65 | 80 | .contract_call::<()>(contract_address, function_name.clone()) | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> contracts/proxy-deployer/src/contract_interactions.rs:80:52 | 80 | .contract_call::<()>(contract_address, function_name.clone()) | ^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `#[warn(clippy::redundant_clone)]` on by default
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L97: contracts/proxy-deployer/src/contract_interactions.rs#L97
warning: length comparison to zero --> contracts/proxy-deployer/src/contract_interactions.rs:97:16 | 97 | && ongoing_upgrade_operation.contracts_remaining.len() > 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ongoing_upgrade_operation.contracts_remaining.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L113: contracts/proxy-deployer/src/contract_interactions.rs#L113
warning: length comparison to zero --> contracts/proxy-deployer/src/contract_interactions.rs:113:12 | 113 | if ongoing_upgrade_operation.contracts_remaining.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ongoing_upgrade_operation.contracts_remaining.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L151: contracts/proxy-deployer/src/contract_interactions.rs#L151
warning: length comparison to zero --> contracts/proxy-deployer/src/contract_interactions.rs:151:13 | 151 | contracts_by_template.len() > 0, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!contracts_by_template.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L80: contracts/proxy-deployer/src/contract_interactions.rs#L80
warning: redundant clone --> contracts/proxy-deployer/src/contract_interactions.rs:80:65 | 80 | .contract_call::<()>(contract_address, function_name.clone()) | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> contracts/proxy-deployer/src/contract_interactions.rs:80:52 | 80 | .contract_call::<()>(contract_address, function_name.clone()) | ^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `#[warn(clippy::redundant_clone)]` on by default
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L97: contracts/proxy-deployer/src/contract_interactions.rs#L97
warning: length comparison to zero --> contracts/proxy-deployer/src/contract_interactions.rs:97:16 | 97 | && ongoing_upgrade_operation.contracts_remaining.len() > 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ongoing_upgrade_operation.contracts_remaining.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L113: contracts/proxy-deployer/src/contract_interactions.rs#L113
warning: length comparison to zero --> contracts/proxy-deployer/src/contract_interactions.rs:113:12 | 113 | if ongoing_upgrade_operation.contracts_remaining.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ongoing_upgrade_operation.contracts_remaining.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[clippy] contracts/proxy-deployer/src/contract_interactions.rs#L151: contracts/proxy-deployer/src/contract_interactions.rs#L151
warning: length comparison to zero --> contracts/proxy-deployer/src/contract_interactions.rs:151:13 | 151 | contracts_by_template.len() > 0, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!contracts_by_template.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

Artifacts

Produced during runtime
Name Size
build-output Expired
2.72 MB