Added copying for metablocks too #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
previously approved these changes
Dec 23, 2024
ssd04
reviewed
Dec 24, 2024
process/outportBlockConverter.go
Outdated
Comment on lines
360
to
363
| return nil, nil | ||
| } | ||
| if len(outportTxPool.Transactions) == 0 { | ||
| return nil, nil |
There was a problem hiding this comment.
i don't think it is fine to return here nil, nil
process/outportBlockConverter.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| func (o *outportBlockConverter) handleTransactionPoolV2(outportTxPool *outport.TransactionPool) (*hyperOutportBlocks.TransactionPoolV2, error) { |
process/outportBlockConverter.go
Outdated
| @@ -535,7 +674,71 @@ func (o *outportBlockConverter) HandleShardOutportBlock(outportBlock *outport.Ou | |||
| return shardOutportBlock, nil | |||
| } | |||
|
|
|||
| func (o *outportBlockConverter) copyTransactions(sourceTxs map[string]*outport.TxInfo, transactionPool *hyperOutportBlocks.TransactionPoolV2) error { | |||
| func (o *outportBlockConverter) copyTransactions(sourceTxs map[string]*outport.TxInfo) (map[string]*hyperOutportBlocks.TxInfo, error) { | |||
There was a problem hiding this comment.
for copyTransactions we return txs and for copyTransactionsV2 we pass the map and modify it, can we have the same approach?
process/outportBlockConverter.go
Outdated
| return txInfo, nil | ||
| } | ||
|
|
||
| func (o *outportBlockConverter) copyTransactionsV2(sourceTxs map[string]*outport.TxInfo, transactionPool *hyperOutportBlocks.TransactionPoolV2) error { |
There was a problem hiding this comment.
why do we still need copyTransactions v1 and v2?
There was a problem hiding this comment.
metaoutportblock is using TxInfoV1. I could switch that as well, and therefore removed the whole versioning.
ssd04
reviewed
Jan 10, 2025
process/outportBlockConverter.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| // HandleShardOutportBlock will convert an outport.OutportBlock to hyperOutportBlocks.ShardOutportBlockV2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added whole copying mechanism similar to the one in shard blocks due to a serialization issue of hashes in proto.