Refactored python scripts #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Sep 18, 2024
popenta
previously approved these changes
Sep 18, 2024
examples/contracts/adder/adder.py
Outdated
| for event in tx.logs.events: | ||
| if event.identifier != "SCDeploy": | ||
| continue | ||
|
|
||
| return factory.create_from_hex(event.topics[0].hex()) | ||
| return Address.from_hex(event.topics[0].hex(), "erd") |
There was a problem hiding this comment.
this could have been new_from_hex(...) but it's ok as it is.
| for event in tx.logs.events: | ||
| if event.identifier != "SCDeploy": | ||
| continue | ||
|
|
||
| return factory.create_from_hex(event.topics[0].hex()) | ||
| return Address.from_hex(event.topics[0].hex(), "erd") |
| @@ -34,11 +35,12 @@ def main(): | |||
|
|
|||
| provider.do_post(f"{SIMULATOR_URL}/simulator/set-state", json_data) | |||
|
|
|||
| factory = AddressFactory("erd") | |||
| wrapp_contract_address = factory.create_from_bech32("erd1qqqqqqqqqqqqqpgqhe8t5jewej70zupmh44jurgn29psua5l2jps3ntjj3") | |||
| wrapp_contract_address = Address.from_bech32( | |||
There was a problem hiding this comment.
here could have been new_from_bech32(...).
examples/movebalance/move-balance.py
Outdated
| amount_egld = 1000000000000000000 # 1 egld | ||
| receiver = AddressFactory("erd").create_from_bech32("erd13kp9r5fx4tf8da4ex37sd48pc4xhkmtteq6hcyt4y36pstte0tjqxjf3ns") | ||
| receiver = Address.from_bech32( |
miiu96
previously approved these changes
Sep 18, 2024
iulianpascalau
dismissed stale reviews from miiu96, popenta, and andreibancioiu
via
9a543fb
popenta
approved these changes
Sep 18, 2024
andreibancioiu
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiversx-sdkpython libgenerate-blocks-until-epoch-reachedandgenerate-blocks-until-transaction-processedendpoint routes wherever possible