Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Readme file #3

Merged
merged 15 commits into from
Nov 22, 2023
Merged

Extend Readme file #3

merged 15 commits into from
Nov 22, 2023

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Nov 16, 2023

  • Test in Python that issue and esdt token
  • Extended Readme.md file
  • Added an extra endpoint for set state
  • Updated version of mx-chain-go module

@miiu96 miiu96 changed the title Extend Readmefile Extend Readme file Nov 16, 2023
@miiu96 miiu96 marked this pull request as ready for review November 16, 2023 13:31
Base automatically changed from readme-file to main November 17, 2023 08:05
@iulianpascalau iulianpascalau self-requested a review November 17, 2023 08:07
@miiu96 miiu96 self-assigned this Nov 21, 2023
README.md Outdated
## Contribution

Contributions to the mx-chain-es-indexer-go module are welcomed. Whether you're interested in improving its features,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Contributions to the mx-chain-es-indexer-go module are welcomed. Whether you're interested in improving its features,
Contributions to the mx-chain-simulator-go module are welcomed. Whether you're interested in improving its features,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


err = ep.facade.SetState(address, keyValueMap)
if err != nil {
shared.RespondWithInternalError(c, errors.New("cannot set state"), err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return statement after this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done



## Contribution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

num-of-shards = 3
# round-duration-in-milliseconds parameter specifies the duration of a simulated round. The timestamp between two headers will correspond to the round duration but will not reflect real-time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miiu96 miiu96 merged commit e9e9ecb into main Nov 22, 2023
3 checks passed
@miiu96 miiu96 deleted the continue-impl branch November 22, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants