Initial implementation #1
Conversation
.github/workflows/golangci-lint.yml
Outdated
| steps: | ||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.20.5 |
There was a problem hiding this comment.
| go-version: 1.20.5 | |
| go-version: 1.20.7 |
to have the same version as in the other flow
cmd/chainsimulator/main.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| log = logger.GetOrCreate("indexer") |
There was a problem hiding this comment.
| log = logger.GetOrCreate("indexer") | |
| log = logger.GetOrCreate("chainSimulator") |
?
pkg/proxy/api/endpoints.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| // ExtendProxyServer will extend the proxy server with extra endponts |
There was a problem hiding this comment.
| // ExtendProxyServer will extend the proxy server with extra endponts | |
| // ExtendProxyServer will extend the proxy server with extra endpoints |
| const ( | ||
| pathToNodeConfig = "../../../mx-chain-go/cmd/node/config" | ||
| pathToProxyConfig = "../../../mx-chain-proxy-go/cmd/proxy/config" |
There was a problem hiding this comment.
suggestion to add path to proxy and node config as cli parameters
There was a problem hiding this comment.
yes, this is done in the next PR
| cmd := exec.Command("cp", "-r", args.PathToProxyConfig, newConfigsPath) | ||
| err := cmd.Run() | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
as suggested above, I think it's not up to this binary to handle node and proxy's configs. Also it seems that here you're just reading the configs so there is no need to copy the proxy config to another location. Or if you really want to copy the configs to a separate temporary location, i think it's better to create a CopyDir function instead of using system binary cp
There was a problem hiding this comment.
Will refactor this in the next PR because there I implemented a function that will copy a folder of a file
pkg/proxy/creator/creator.go
Outdated
|
|
||
| proxyInstance.closableComponents.Add(nodeGroupProc, valStatsProc, nodeStatusProc, bp) | ||
|
|
||
| //nodeGroupProc.StartCacheUpdate() |
There was a problem hiding this comment.
We don't need heartbeats here, so I will remove this commented line.
pkg/proxy/creator/creator.go
Outdated
| log.Error("cannot ListenAndServe()", "err", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
return error here? there is already an os.Exit(1) in main.go in case of error
There was a problem hiding this comment.
removed and changed the log
pkg/proxy/creator/creator.go
Outdated
|
|
||
| func (p *proxy) GetHttpServer() *http.Server { |
cmd/chainsimulator/main.go
Outdated
| //buildInfo, ok := debug.ReadBuildInfo() | ||
| //if !ok { | ||
| // panic("Can't read BuildInfo") |
| } | ||
|
|
||
| startTime := time.Now().Unix() | ||
| roundDurationInMillis := uint64(6000) |
There was a problem hiding this comment.
suggestion to parametrize this in a next PR
There was a problem hiding this comment.
it's done in the next PR
|
|
||
| startTime := time.Now().Unix() | ||
| roundDurationInMillis := uint64(6000) | ||
| roundsPerEpoch := core.OptionalUint64{ |
There was a problem hiding this comment.
suggestion to parametrize this in a next PR
There was a problem hiding this comment.
it's done in the next PR
| Value: 20, | ||
| } | ||
|
|
||
| apiConfigurator := api.NewFreePortAPIConfigurator("localhost") |
There was a problem hiding this comment.
suggestion to parametrize this in a next PR
There was a problem hiding this comment.
it's done in the next PR
| } | ||
|
|
||
| apiConfigurator := api.NewFreePortAPIConfigurator("localhost") | ||
| simulator, err := chainSimulator.NewChainSimulator(os.TempDir(), 3, pathToNodeConfig, startTime, roundDurationInMillis, roundsPerEpoch, apiConfigurator) |
There was a problem hiding this comment.
suggestion to parametrize number of shards in a next PR
There was a problem hiding this comment.
it's done in the next PR
| @@ -0,0 +1,6 @@ | |||
| package facade | |||
|
|
|||
| type SimulatorHandler interface { | |||
pkg/proxy/configs/configs.go
Outdated
| for shardID, nodeAPIInterface := range args.RestApiInterfaces { | ||
| cfg.Observers = append(cfg.Observers, &data.NodeData{ | ||
| ShardId: shardID, | ||
| Address: "http://" + nodeAPIInterface, |
There was a problem hiding this comment.
const for "http://" ?
| } | ||
|
|
||
| // CreateProxy will create a new instance of proxy | ||
| func CreateProxy(args ArgsProxy) (proxy2.ProxyHandler, error) { |
There was a problem hiding this comment.
with a little bit of code refactoring in the proxy repo, we can reuse this construction part. Not for this PR.
There was a problem hiding this comment.
yes, will make a task to refactor the proxy main.go file
chainsimulatorbinary/simulator/generate-blocks/:num-blocksthat will generate a provided number of blocks for every shard