Handle relayed V1, intra-shard, with signal error #99
+143
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich result in signal error - before vs. after Sirius.
andreibancioiu
commented
Aug 22, 2024
Comment on lines
+263
to
+267
| { | ||
| Type: opTransfer, | ||
| Account: addressToAccountIdentifier(receiverAddress), | ||
| Amount: transformer.extension.valueToNativeAmount(innerTx.Value.String()), | ||
| }, |
There was a problem hiding this comment.
Since now we also handle contracts (the receiver in this particular, exotic case).
andreibancioiu
commented
Aug 22, 2024
| // - https://github.com/multiversx/mx-chain-rosetta/pull/81/files | ||
| // - https://console.cloud.google.com/bigquery?sq=667383445384:bfeb7de9aeec453192612ddc7fa9d94e | ||
| func (transformer *transactionsTransformer) extractInnerTxOperationsIfBeforeSiriusRelayedCompletelyIntrashardWithSignalError(tx *transaction.ApiTransactionResult) ([]*types.Operation, error) { | ||
| if transformer.provider.IsReleaseSiriusActive(tx.Epoch) { |
There was a problem hiding this comment.
Ideally, we will remove extractInnerTxOperationsIfBeforeSiriusRelayedCompletelyIntrashardWithSignalError sometimes soon, because, most probably, reconciliation for such old transactions isn't necessary.
danidrasovean
approved these changes
Aug 22, 2024
miiu96
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle relayed V1, completely intra-shard, whose inner transaction moves native value, which result in signal error - before vs. after Sirius.
See older PR:
#81.
See BigQuery report (analysis of this exotic scenario):
https://console.cloud.google.com/bigquery?sq=667383445384:bfeb7de9aeec453192612ddc7fa9d94e