Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperblock new parameter #475

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Hyperblock new parameter #475

merged 4 commits into from
Jan 9, 2025

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Dec 23, 2024

  • Added URL parameter forHyperblock when blocks are fetched by the /hyperblock endpoint

@miiu96 miiu96 self-assigned this Dec 23, 2024
@miiu96 miiu96 mentioned this pull request Dec 23, 2024
Merged
sstanculeanu
sstanculeanu previously approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@sstanculeanu sstanculeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be retargeted to a rc branch

ssd04
ssd04 reviewed Dec 24, 2024
View reviewed changes
common/options.go Outdated Show resolved Hide resolved
@miiu96 miiu96 changed the base branch from master to rc/spica-patch-relayedv3 December 27, 2024 11:40
@miiu96 miiu96 dismissed sstanculeanu’s stale review December 27, 2024 11:40

The base branch was changed.

sstanculeanu
sstanculeanu previously approved these changes Jan 8, 2025
View reviewed changes
ssd04
ssd04 previously approved these changes Jan 8, 2025
View reviewed changes
@sstanculeanu sstanculeanu dismissed stale reviews from ssd04 and themself via dd444df January 9, 2025 12:55
@AdoAdoAdo AdoAdoAdo merged commit ffc3f61 into rc/spica-patch-relayedv3 Jan 9, 2025
5 checks passed
@sstanculeanu sstanculeanu deleted the hyper-block-new-parameter branch January 9, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danidrasovean danidrasovean danidrasovean approved these changes

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

@ssd04 ssd04 ssd04 approved these changes

@sstanculeanu sstanculeanu sstanculeanu left review comments

Assignees

@miiu96 miiu96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miiu96 @ssd04 @sstanculeanu @AdoAdoAdo @danidrasovean