Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Fix shard id computations #6722

Open
wants to merge 4 commits into
base: feat/chain-go-sdk
Choose a base branch
from

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Jan 21, 2025

Reasoning behind the pull request

  • Fix shard ID computation for sovereign chain
    ProcessDestinationShardAsObserver & AssignShardForPubKeyWhenNotSpecified have not been changed, but should work as expected to return SovereignChainShardID as long as config is also correct

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Jan 21, 2025
@mariusmihaic mariusmihaic marked this pull request as ready for review January 21, 2025 13:36
axenteoctavian
axenteoctavian previously approved these changes Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants