Bug-fix: Fix /transaction/cost api route #5878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5878 +/- ##
==========================================
- Coverage 80.14% 80.14% -0.01%
==========================================
Files 708 708
Lines 94043 94055 +12
==========================================
+ Hits 75373 75380 +7
- Misses 13326 13329 +3
- Partials 5344 5346 +2 ☔ View full report in Codecov by Sentry. |
| @@ -63,6 +66,9 @@ func NewAPITransactionEvaluator(args ArgsApiTransactionEvaluator) (*apiTransacti | |||
| if check.IfNil(args.EnableEpochsHandler) { | |||
| return nil, process.ErrNilEnableEpochsHandler | |||
| } | |||
| if check.IfNil(args.BlockChain) { | |||
| return nil, process.ErrNilBlockChain | |||
| @@ -84,7 +91,9 @@ func (ate *apiTransactionEvaluator) SimulateTransactionExecution(tx *transaction | |||
| ate.mutExecution.Unlock() | |||
| }() | |||
|
|
|||
| return ate.txSimulator.ProcessTx(tx) | |||
| currentHeader := ate.blockChain.GetCurrentBlockHeader() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
BlockChainHookused inside the components that calculate the transaction cost: BlockChainHook didn't have aCurrentHeaderset.Proposed changes
BlockChainHookused for transaction cost computation.Testing procedure
devneton shard 1 with this branch and ensure the cost is computed correctly for the example from themx-chain-proxy-goGitHub issuePre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?