[sovereign] Fix epoch start pointer receivers interfaces #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eceivers # Conflicts: # data/block/sovereignChainHeader.go
sasurobert
approved these changes
Dec 11, 2024
| } | ||
|
|
||
| // SetLastFinalizedHeaders sets epoch start data for main chain chain only | ||
| func (m *EpochStartSovereign) SetLastFinalizedHeaders(epochStartShardDataHandlers []data.EpochStartShardDataHandler) error { |
There was a problem hiding this comment.
This function is not used anywhere in mx-chain-go
There was a problem hiding this comment.
Doesn't matter, I had to follow the interface for EpochStart, which should have getters and setters for all fields.
axenteoctavian
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetEpochStartHandlerfromSovereignChainHeaderused to return a pointer reference to a completely different type of struct from mainnchain structs (EpochStart), whereas we use another structEpochStartSovereign. This would cause setters and getters fromSovereignChainHeaderto not work properly.