add on-the-fly mutexes by key #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raduchis
requested changes
Sep 20, 2024
|
|
||
| // Unlock unlocks the Mutex for the given key | ||
| func (km *keyRWMutex) Unlock(key string) { | ||
| km.getForUnlock(key).unlock() |
There was a problem hiding this comment.
if not found, nil will be returned and it will panic
There was a problem hiding this comment.
created on getForUnlock if not existing, so that it panics because of an Unlock on an unlocked mutex instead of dereferencing a nil pointer.
|
|
||
| // RUnlock unlocks for read the Mutex for the given key | ||
| func (km *keyRWMutex) RUnlock(key string) { | ||
| km.getForRUnlock(key).rUnlock() |
There was a problem hiding this comment.
if not found (or two unlocks), nil will be returned and it will panic
There was a problem hiding this comment.
created on getForRUnlock if not existing, so that it panics because of an RUnlock on an unlocked mutex instead of dereferencing a nil pointer.
raduchis
approved these changes
Sep 20, 2024
cristure
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.