Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internacionalization + spanish traduction #44

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

elmarceloc
Copy link

-internationalization
-spanish internationalization

-internationalization
-spanish internationalization
@elmarceloc
Copy link
Author

I think that @mikirobles can corroborate the translation into Spanish, since he is from Argentina

@elmarceloc elmarceloc changed the title Internacionalization Internacionalization + spanish traduction Apr 23, 2022
@elmarceloc
Copy link
Author

for firefox, the code would be pretty much the same, i think instead of chrome.18n would be browser.18n
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization

Copy link
Contributor

@mikirobles mikirobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested by @elmarceloc, leaving my review of the spanish strings + some of the i18n keys as well

chrome/_locales/en/messages.json Outdated Show resolved Hide resolved
chrome/_locales/en/messages.json Outdated Show resolved Hide resolved
chrome/_locales/es/messages.json Outdated Show resolved Hide resolved
chrome/_locales/es/messages.json Outdated Show resolved Hide resolved
chrome/_locales/es/messages.json Outdated Show resolved Hide resolved
chrome/_locales/es/messages.json Outdated Show resolved Hide resolved
chrome/_locales/es/messages.json Outdated Show resolved Hide resolved
chrome/popup/index.html Outdated Show resolved Hide resolved
chrome/popup/index.html Outdated Show resolved Hide resolved
@elmarceloc
Copy link
Author

ohh so many typos, I think I was very sleepy, thanks for the review and have a great day!

elmarceloc and others added 9 commits April 23, 2022 15:22
better grammer

Co-authored-by: Micael Robles <[email protected]>
typo

Co-authored-by: Micael Robles <[email protected]>
typo

Co-authored-by: Micael Robles <[email protected]>
@mikirobles
Copy link
Contributor

mikirobles commented Apr 23, 2022

ohh so many typos, I think I was very sleepy, thanks for the review and have a great day!

No problem, glad I could be of help

@muleyo
Copy link
Owner

muleyo commented Apr 25, 2022

Hi, thanks for the translation.

I'll review this asap and approve it.

Copy link

@diomonogatari diomonogatari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, I've found this and decided that I could participate a bit.
I'm from Portugal, although not exactly pt_BR speaker (I'm pt_PT), wanted to provide some feedback on the translations and left the regionalisms unchanged.

Cheers

@@ -0,0 +1,28 @@
{
"extDescription": {
"message": "Bloquear anúncios nas transmissões da Twitch.tv.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified to "Bloqueia anúncios na Twitch.tv."

"description": "A descrição da extensão."
},
"toggleAdblocker": {
"message": "Bloquear anúncios"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest "Bloquear anúncios Off / On" to keep the EN format?

"message": "Bloquear anúncios"
},
"toggleBlockingAds": {
"message": "Aviso de \"Bloqueando anúncios\"",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not entirely a warning message, "Mensagem de "Bloqueando anúncios" Off / On" is my suggestion

"description": "Ativar ou desativar a mensagem 'Bloqueando anúncios...'"
},
"reloadTabsWarning": {
"message": "Sempre que você alterar uma configuração da extensão, você vai precisar recarregar a(s) guia(s) da Twitch."
Copy link

@diomonogatari diomonogatari Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified to:
"Sempre que alterar uma configuração, você precisa de recarregar a(s) guia(s) da Twitch.".

Also, is the term "guia" actually used daily to refer to browser tabs? From experience, the loan word "tabs" is the most used term in PT

"message": "Sempre que você alterar uma configuração da extensão, você vai precisar recarregar a(s) guia(s) da Twitch."
},
"popupReminder": {
"message": "Você pode acessar as configurações a qualquer momento apenas clicando no ícone da extensão"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest "Poderá acessar às configurações a qualquer momento ao clicar no ícone da extensão" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants