Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: replace "Toolpad" default title with empty string #4446

Closed
wants to merge 1 commit into from

Conversation

Petar-Dimitrov-AXA
Copy link

As discussed in issue #4445, I replaced the default "Toolpad" title with an empty string.

@bharatkashyap bharatkashyap added the enhancement This is not a bug, nor a new feature label Nov 21, 2024
@Janpot
Copy link
Member

Janpot commented Nov 21, 2024

You should be able to set it to empty string on the user side. I think I'm in favor of keeping a default of "Toolpad", because it makes this option more discoverable.

@Petar-Dimitrov-AXA
Copy link
Author

If that's the case, please consider adding a disableHeaderTitle prop. Setting the title to '' from client side feels kind a pointless. It would be ideal if there's a disableHeaderTitle boolean prop so that the title node will not render.

@Janpot
Copy link
Member

Janpot commented Nov 21, 2024

To add more options, perhaps a bit more versatile is to have a prop on the DashboardLayout to override the title? Set it to any value you want to override the branding context, or empty string to disable altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants