[charts] Fix zoom option reactivity #16262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-16262--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #16262 will not alter performanceComparing Summary
|
JCQuintas
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next.mui.com/x/react-charts/zoom-and-pan/#zooming-options were broken because the zoomOptionLookup that maps axis id to its zoom options was computed on the initial render and never updated.
This PR removes it from the internal state and moves it to selectors as a derived state from and axis config.
It's still computed in the params defaultizer because it's required to initialize the zoom state