[charts] Expand line with step interpolation #16229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-16229--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #16229 will not alter performanceComparing Summary
|
alexfauquette
changed the title
JCQuintas
approved these changes
Jan 18, 2025
Comment on lines
68
to
+73
| curve?: CurveType; | ||
| /** | ||
| * If `true`, step curve starts and end at the first and last point. | ||
| * By default the line is extended to fill the space before and after. | ||
| */ | ||
| strictStepCurve?: boolean; |
There was a problem hiding this comment.
Would addind a curve: 'strict-step' option a cleaner approach than this flag? 🤔
There was a problem hiding this comment.
Not really because we also have step-before and step-after.
I do not expect people to use this flag. The docs is more here to highlight the special behavior on band scale than to encourage using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16183
For me that's not realy a breaking change. It's more of an improvement