[DataGrid] Scroll restoration #15623
Merged
+221
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15623--material-ui-x.netlify.app/ Updated pages: |
romgrk
reviewed
Nov 26, 2024
packages/x-data-grid/src/components/virtualization/GridVirtualScrollbar.tsx
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Nov 26, 2024
packages/x-data-grid/src/components/virtualization/GridVirtualScrollerContent.tsx
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Nov 26, 2024
packages/x-data-grid/src/hooks/features/virtualization/useGridVirtualScroller.tsx
Outdated
Show resolved
Hide resolved
zannager
added
the
component: data grid
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@romgrk, I merged the recent changes into the PR. Great if we could get this PR merged next – dying to get rid of some of the hacks in our app that we have had to come up with to get this to work in user land. Thanks! 🙏 |
romgrk
approved these changes
Jan 15, 2025
romgrk
added
the
needs cherry-pick
cherniavskii
pushed a commit
to cherniavskii/mui-x
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15190
Pain to implement in userland currently, avoids recalculating render contexts and trashing wrong initial content, that's impossible to avoid in userland.
Added a section under scrolling in docs to demonstrate.