Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic functionality - swap sides command #7865

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Nov 4, 2024

Just adding my WIP as I go. This is intended as part of a teaching mode/new player mode, so the more experienced player can demonstrate a concept or show stuff.

  • Since the command needs to manipulate the lobby, it needs to happen outside of the commands interface (in game.clj). I'll update it later to make it 1) a dedicated button and 2) not a regular command
  • It needs to have double-sided consent (like undo turn)
  • Right now, the stats panels on the left (where credits/etc are) don't update when sides get swapped. This is similar to starting a private game after ending another private game, with sides opposite. Fixing that bug will fix this bug - we essentially need to find a way to make those panels actually scry the gamestate for your side instead of checking some cached side in a cached view of the lobby somewhere.
  • You should be able to swap back without consent (or revoke consent)
  • Things should get logged

Sooner or later I'll figure this all out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant