msys2-runtime: integrate suspendthread fixup #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to msys2/msys2-runtime#239 and integrates one minor change of behavior where `remove_proc()` now _also_ tries `CancelSynchronousIo()` before using the big `terminate_thread()` hammer. Probably not a very noticeable change of behavior. But still. Better stay aligned with Cygwin! Signed-off-by: Johannes Schindelin <[email protected]>
|
This is not merged yet, so at least I know the hang is not the additional CancelSynchronousIo call... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to msys2/msys2-runtime#239 and integrates one minor change of behavior where
remove_proc()now also triesCancelSynchronousIo()before using the bigterminate_thread()hammer.Probably not a very noticeable change of behavior. But still. Better stay aligned with Cygwin!