Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5194
👩🏻💻 What does this PR do?
This removes redundant aliasing of Diesel DSLs. According to Diesel's documentation, the dsl alias is only useful when dealing with a single table. We should use DSL for convenience if we are working with just one table in a module, but for the rest, we don't need to alias them.
💌 Any notes for the reviewer?
This is quite the hefty review. In order to make things easier, I've pushed the changes in batches. I was considering different PRs, but I didn't want our project to be filled with them.
See the link below for each commit. Hope it helps 😃
🧪 Testing
📃 Documentation
1.
6.